TeamCity shouldn't notify if a build fails with the same error as the previous build : TW-1649

Back to Search

Project	TeamCity
Priority	Critical
Type	Bug
State	Fixed
Assignee	Kirill Maximov
Subsystem	Server
Affected versions	TeamCity 1.1
Fix versions	Agra EAP (3914)
Fixed in build	17577
Fixed in builds	no build yet

Created by Gibson
5 years ago (08 Feb 2007 15:55)
Updated by Yegor Yarko
12 months ago (10 May 2011 18:22)
Jira: TW-1649
(history, comments)

TW-1649 TeamCity shouldn't notify if a build fails with the same error as the previous build

Issue is visible to: All Users

Links — Show as list

Relates to:
TW-14180

teamcity.log.gz (117 KB)

I have a build that fails several times on the same agent with the same error. I would like a way to only receive notifications the first time it fails - apparently this is the way it is supposed to work, but it doesn't.

Attached the log from the relevant agent. Below is the test failure, which is the same every time.

junit.framework.AssertionFailedError: Differences found

…

junit.framework.AssertionFailedError: Differences found
 at junit.framework.Assert.fail(Assert.java:47)
 at junit.framework.Assert.assertTrue(Assert.java:20)
 at junit.framework.Assert.assertFalse(Assert.java:34)
 at com.xxx.gui.productvalidator.ProductTest$5.test(ProductTest.java:221)
 at com.xxx.apps.tests.products.ProductsFromFiles.testFile(ProductsFromFiles.java:144)
 at com.xxx.apps.tests.products.ProductsFromFiles.testFiles(ProductsFromFiles.java:37)
 at com.xxx.apps.tests.products.SevenOURSTest.testSevenOURS(SevenOURSTest.java:11)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at junit.framework.TestCase.runTest(TestCase.java:164)
 at junit.framework.TestCase.runBare(TestCase.java:130)
 at junit.framework.TestResult$1.protect(TestResult.java:110)
 at junit.framework.TestResult.runProtected(TestResult.java:128)
 at junit.framework.TestResult.run(TestResult.java:113)
 at junit.framework.TestCase.run(TestCase.java:120)
 at junit.framework.TestSuite.runTest(TestSuite.java:228)
 at junit.framework.TestSuite.run(TestSuite.java:223)
 at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
 at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
 at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:546)

Issue wasresolved

Gibson

08 Feb 2007 15:56

5 years ago

By the way, the current behaviour is useful in some circumstances, is it possible to have it as an option (see TW-764)?

Gibson

08 Feb 2007 17:54

5 years ago

More generally, is there any debug which will tell me why I've received a given notification (e.g. failing build with my change, failed build that I'm watching, ...)?

Kirill Maximov

14 Mar 2007 22:56

5 years ago

In the next EAP, when looking at build history, there will be "signature" comment for each build.

If the signature of a build is the same as for the previous build, failure notification for the build should not be sent to users, who already got notification for the previous build.

Gibson

15 Mar 2007 12:26

5 years ago

Not sure I understand, is the "signature" generated automatically or is a comment that we have to put manually?
Anyway, I'm looking forward to testing it out!

Kirill Maximov

15 Mar 2007 13:45

5 years ago

signature is a autogenerated number based on build output. We consider two builds fail the same way when their signature match each other. It is something like hashcode for the build, which includes failed tests, exceptions etc.

Gibson

15 Mar 2007 14:50

5 years ago

Great, thanks.

Gibson

15 Mar 2007 14:51

5 years ago

By the way, is this in option? By default I think this is the desired behaviour, but I may in certain circumstances want to receive notification on every build failure.

Gibson

22 Mar 2007 12:37

5 years ago

Doesn't seem to be working as you suggest:
I have the following for my e-mail notification

Watch builds                     Send notification when
MyProject All configurations        * - Build failed
                                * - Responsibility changes
Builds with my changes            * - Build failed

And I just got the same build failure notification for 3 builds in a row (only the first one was a "new" failure).
The output from these builds is exactly the same, so the signature should be the same?

Kirill Maximov

22 Mar 2007 14:12

5 years ago

Robert, in fact signature plays only for "builds with my changes".
If you subscribed on "Build failed" notification for particular configuration, you'll get notification for every failed build (just like for "successful builds" notification.

Unfortunately, we haven't described this behaviour in documentation yet.

Gibson

22 Mar 2007 14:29

5 years ago

Kirill, thanks for the clarification.
I would like to configure TC so that it only notifies me if my changes have broken a build - that is, if I check in changes on a build that is already failing and I don't change the signature of the build failure, I don't want to be notified. Is that currently possible?

Kirill Maximov

22 Mar 2007 14:58

5 years ago

Unfortunately, no.

In the described situation you'll get the notification about failed build with your change. But you won't get subsequent notifications if next build fails the same way as previous one.

Kirill Maximov

22 Mar 2007 14:59

5 years ago

You may try to setup additional email filter based on the "new" test information line in the notification.

Gibson

22 Mar 2007 15:25

5 years ago

OK, added a feature request
TW-2113